I'm a waist size 32-34 and went for the medium size based on other reviews, I have fairly muscular legs and the shorts fit well and look pretty good when on. But for me it isn't about how they look, its about what they do.
I am 70% pleased with the purchase and the shorts will be useful in training etc but if I saw these in the shops I would have not been tempted by the price tag to buy them and would look for something better, I have taken a long time to shop around on line for a good deal as compression shorts prices seem to range from £15 - £100 and I feel I fell victim of reading positive reviews about these shorts from people who have nothing to compare them too.
I also have a pair of Nike Pro full length tights that have a thicker stickier wet suit type of material that stays in place and you can feel the muscles being squeezed and these weren't that much more expensive than the ones here and worth the extra money.
The shorts I just received offer very little in terms of compression, don't get me wrong, yes they hug your legs and feel tight against the body but they do not compress.....there is a difference!
The elastic waist band also works its way down your body as you walk around (this is not because I brought the wrong size but due to the material is silky and the waist band is not elastic enough)
If you main goal is to stay warmer during sport or to have less movement in the manhood department then these will be a great choice for the great value that they are. If your goal is to help prevent injuries, recovery, aid circulation, performance etc, then please go spend a lil more and avoid feeling disappointed.